Env 7 / Node 4 useBuiltIns usage transpiling polyfill call with "import" not "require"

[reggi]

Here's my config:

{
  "babel": {
    "presets": [
      [
        "@babel/preset-env",
        {
          "targets": {
            "node": "4.0.0"
          },
          "useBuiltIns": "usage",
          "debug": true,
          "shippedProposals": true
        }
      ]
    ]
  }
  "devDependencies": {
    "npm-run-all": "^4.1.2",
    "@babel/cli": "^7.0.0-beta.40",
    "@babel/core": "^7.0.0-beta.40",
    "@babel/preset-env": "^7.0.0-beta.40",
    "babel-core": "^7.0.0-bridge.0",
    "babel-jest": "^22.4.1",
    "jest": "^22.4.2"
  }
}

Here's debug output:

@babel/preset-env: `DEBUG` option

Using targets:
{
  "node": "4"
}

Using modules transform: commonjs

Using plugins:
  transform-arrow-functions { "node":"4" }
  transform-block-scoping { "node":"4" }
@babel/preset-env: `DEBUG` option
  transform-classes { "node":"4" }
  transform-destructuring { "node":"4" }
  transform-for-of { "node":"4" }
  transform-function-name { "node":"4" }
  transform-object-super { "node":"4" }
  transform-parameters { "node":"4" }
  transform-spread { "node":"4" }
  transform-sticky-regex { "node":"4" }
  transform-unicode-regex { "node":"4" }
  transform-new-target { "node":"4" }
  transform-regenerator { "node":"4" }
  transform-exponentiation-operator { "node":"4" }
  transform-async-to-generator { "node":"4" }
  transform-dotall-regex { "node":"4" }
  proposal-async-generator-functions { "node":"4" }

Using targets:
  proposal-object-rest-spread { "node":"4" }
  proposal-optional-catch-binding { "node":"4" }
  proposal-unicode-property-regex { "node":"4" }

Using polyfills with `usage` option:
{
  "node": "4"
}

Using modules transform: commonjs

Using plugins:
  transform-arrow-functions { "node":"4" }
  transform-block-scoping { "node":"4" }
  transform-classes { "node":"4" }
  transform-destructuring { "node":"4" }
  transform-for-of { "node":"4" }
  transform-function-name { "node":"4" }
  transform-object-super { "node":"4" }
  transform-parameters { "node":"4" }
  transform-spread { "node":"4" }
  transform-sticky-regex { "node":"4" }
  transform-unicode-regex { "node":"4" }
  transform-new-target { "node":"4" }
  transform-regenerator { "node":"4" }
  transform-exponentiation-operator { "node":"4" }
  transform-async-to-generator { "node":"4" }
  transform-dotall-regex { "node":"4" }
  proposal-async-generator-functions { "node":"4" }
  proposal-object-rest-spread { "node":"4" }
  proposal-optional-catch-binding { "node":"4" }
  proposal-unicode-property-regex { "node":"4" }

Using polyfills with `usage` option:

[./functionality/bin/index.js] Based on your code and targets, none were added.

[./functionality/index.js] Added following polyfills:
  es7.array.includes { "node":"4" }
  regenerator-runtime { "node":"4" }
  es6.promise { "node":"4" }

Why on earth does my index.build.js file have an import statment?

./functionality/index.js

import "core-js/modules/es6.promise";

require("regenerator-runtime/runtime");

require("core-js/modules/es7.array.includes");

[babel-bot]

Hey @reggi! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

[mAAdhaTTah]

You need modules: "commonjs" in your config. See here.

Edit: Nevermind. That should be on by default. Do you have a repro case?

[loganfsmyth]

Good call. preset-env should be using https://github.com/babel/babel/blob/master/packages/babel-helper-module-imports/README.md to handle this, and currently it is hardcoded to create import statements.

[Jessidhia]

https://github.com/babel/babel/blob/007f8d19/packages/babel-preset-env/src/use-built-ins-plugin.js#L46 is the culprit. It's calling an ad-hoc createImport helper, which has a 3rd option to support require instead of import, but it's never given.

Maybe something that was added before preset-env got moved to the monorepo and thus got missed when the helper was introduced.

[loganfsmyth]

Yeah I think that is likely the case. Should be a simple fix.

[debugpai]

I would like to work on this

[existentialism]

Maybe something that was added before preset-env got moved to the monorepo and thus got missed when the helper was introduced.

That is definitely the case :)

Ref: #6601 as well.

[loganfsmyth]

@debugpai2 Go for it!