Improve error message on attempt to destructure named import

babel · Jan 12, 2017 · f231993 · f231993
1 parent aa1a4be
commit f231993
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/src/parser/statement.js b/src/parser/statement.js
@@ -1060,6 +1060,11 @@ pp.parseImportSpecifiers = function (node) {
     if (first) {
       first = false;
     } else {
+      // Detect an attempt to deep destructure
+      if (this.eat(tt.colon)) {
+        this.unexpected(null, "ES2015 named imports do not destructure. Use another statement for destructuring after the import.");
+      }
+
       this.expect(tt.comma);
       if (this.eat(tt.braceR)) break;
     }

diff --git a/test/fixtures/es2015/uncategorised/392/actual.js b/test/fixtures/es2015/uncategorised/392/actual.js
@@ -0,0 +1 @@
+import foo, { bar: { a } } from 'my-module';
diff --git a/test/fixtures/es2015/uncategorised/392/options.json b/test/fixtures/es2015/uncategorised/392/options.json
@@ -0,0 +1,4 @@
+{
+  "throws": "ES2015 named imports do not destructure. Use another statement for destructuring after the import. (1:19)",
+  "sourceType": "module"
+}