Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

Fix #321 by allowing question marks in type params #338

Merged
merged 2 commits into from
Feb 10, 2017
Merged

Fix #321 by allowing question marks in type params #338

merged 2 commits into from
Feb 10, 2017

Conversation

danez
Copy link
Member

@danez danez commented Jan 31, 2017

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets Fixes #321
License MIT

This reverses the logic of the loop inside flowParseFunctionTypeParams, which does not only allow name tokens but any token besides parenR and ellipsis.

//cc @gabelevi

@codecov-io
Copy link

codecov-io commented Jan 31, 2017

Codecov Report

Merging #338 into master will increase coverage by <.01%.

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
+ Coverage   97.65%   97.65%   +<.01%     
==========================================
  Files          20       20              
  Lines        3326     3327       +1     
  Branches      882      883       +1     
==========================================
+ Hits         3248     3249       +1     
  Misses         30       30              
  Partials       48       48
Impacted Files Coverage Δ
src/plugins/flow.js 97.53% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898c4a7...209ae11. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse error on unnamed optional param in function type annotation
2 participants