-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not transform imports to use the Ember global for [email protected] and higher #387
Merged
rwjblue
merged 2 commits into
emberjs:master
from
patocallaghan:patoc/no-module-polyfill
Mar 17, 2021
Merged
Do not transform imports to use the Ember global for [email protected] and higher #387
rwjblue
merged 2 commits into
emberjs:master
from
patocallaghan:patoc/no-module-polyfill
Mar 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patocallaghan
force-pushed
the
patoc/no-module-polyfill
branch
from
March 16, 2021 22:14
75e2f5e
to
a6c3862
Compare
rwjblue
reviewed
Mar 16, 2021
pzuraq
approved these changes
Mar 17, 2021
rwjblue
approved these changes
Mar 17, 2021
rwjblue
changed the title
Do not transform imports to Ember Global on certain versions of ember-source
Do not transform imports to use the Ember global for [email protected] and higher
Mar 17, 2021
This was referenced Mar 18, 2021
Closed
Merged
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR supersedes #382
So after some discussion in #dev-ember-js there's been a change of plan with regards deprecating Ember Global support.
Now, rather than using
babel-plugin-ember-modules-api-polyfill
'suseEmberModule
option to transform packages to their global equivalents and use an importedEmber
, the plan is to no longer transform Ember package imports to use the Ember Global.Source file
Versions of
ember-source
less than 3.27.0-alpha.1Versions of
ember-source
greater than or equal to 3.27.0-alpha.1