Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change name of variable to be more accurate #388

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Change name of variable to be more accurate #388

merged 1 commit into from
Mar 18, 2021

Conversation

patocallaghan
Copy link
Contributor

Just a tiny bit of cleanup from #387. This suggested variable rename was missed in the original PR.

@pzuraq
Copy link
Collaborator

pzuraq commented Mar 17, 2021

oh huh, could have sworn I changed this 🤔 my bad, thanks for the update!

@patocallaghan
Copy link
Contributor Author

patocallaghan commented Mar 17, 2021 •
edited
Loading

@pzuraq you did PRE_EMBER_MODULE_IMPORTS_VERSION, this is POST_EMBER_MODULE_IMPORTS_VERSION

@pzuraq
Copy link
Collaborator

pzuraq commented Mar 17, 2021

Ahhh, that was it 😄

rwjblue
rwjblue approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rwjblue rwjblue merged commit c10dc84 into emberjs:master Mar 18, 2021
@patocallaghan patocallaghan deleted the patoc/change-variable-name branch March 18, 2021 09:37
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patocallaghan @pzuraq @rwjblue