fix: write client ID back to config file on-the-fly #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitsalis
approved these changes
Feb 6, 2023
|
Merged for now. As per offline discussion with @philmln we will use LevelDB for storing the client ID in the future. This will be done in a subsequent PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BM-490
This PR introduces the mechanism to write the client ID back to config file on-the-fly after creating an IBC light client. This allows the relayer to reuse the client it created in the last run, thus saving some gas costs. The majority of the code is adapted from https://github.com/cosmos/relayer/blob/v2.2.0/cmd/appstate.go. The process of writing config file is made thread-safe by using filesystem locks. Tested locally and it works properly.
Along the way, this PR cleans up the config in the sense that 1)
memois now totally fetched from config rather than cli flags, and 2)cfgis now a field ofRelayerstruct thus we don't need to pass chains/paths toRelayerfunctions anymore.