Functionality for building custom mainnet tags #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonradStaniec
approved these changes
Sep 26, 2022
vitsalis
added a commit
to babylonchain/vigilante
that referenced
this pull request
Sep 29, 2022
In a previous version, Babylon only allowed specifying a `bbnm` tag through its `MainTag` functionality. However, this did not allow to use indexed tags. This functionality is enabled by the addition of [#157](babylonchain/babylon#157) on the Babylon repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the Babylon config allows for custom mainnet tags (e.g.
bbn0,bbn42), thebtctxformattermodule does not provide support for building those (in contrast with the testnet tags). This PR adds functionality that replicates the one implemented for testnet tags. This is going to be needed, since we might have different deployments of the mainnet which would require a different tag thanbbnm.