Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Implement Msg interface for MsgInsertBTCSpvProof #20

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

vitsalis
Copy link
Member

ignite chain serve was failing due to the following error:

>>> ignite chain serve
panic: can't register request type *types.InsertBTCSpvProofRequest for service method /babylonchain.babylon.btccheckpoint.Msg/InsertBTCSpvProof

[stack trace]

After some investigation, this seems to be due to the InsertBTCSpvProofRequest message not implementing the Msg interface. Added that and also modified the proto files to use the package and naming convention that we use on other modules.

Copy link
Collaborator

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixining this 👍 One note though, I would avoid testing stuff using ignite, as this is not something we will support, the same failure can be achieved by running local net via make localnet-start

@vitsalis vitsalis merged commit eb097a6 into main Jun 21, 2022
@vitsalis vitsalis deleted the fix-btcspvproof-msg branch June 21, 2022 16:11
KonradStaniec pushed a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants