zoneconcierge: find the earliest epoch that finalised a chain info for the API #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #220
This PR fixes a bug in the
FinalizedChainInfoAPI that, it does not return the earliest epoch that finalised the chain info in the last finalised epoch. Specifically, it's possible that a chain info is finalised in an early epoch, then the relayer goes offline, and all subsequent epochs snapshot this chain info.This PR fixes this by tracking the epoch number of each indexed header, such that it allows the API to find the earliest epoch that finalises this header.