-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BM-31: Add CircleCI pipeline for building and testing #23
Conversation
Just fyi, in previous org/repo we used CircleCi - https://github.com/babylonchain-io/bbld/pull/2/files, due to the fact that github actions at some point blocked whole org, with explanation that we are somehow in breach of their regulations for crypto projects. Of course they did not provide any detail, and contact with them was terrible. So maybe we should stick with it here also, wdyt @fishermanymc ? |
I am not familar with Github Actions, so this may be a stupid question, but why do we need a separate workflow for build and test, why not have one workflow with both steps? Both run on |
@aakoshh Not a requirement, I just figured that building and testing might have separate workflows in the future which would warrant some separation. Can combine those and achieve the same result for now. |
Agreed. Let's avoid Github Action. Last time it thought we were using it for mining and red flag our entire organization and does not allow me to appeal. Let's use Circle CI. |
Sounds good. @fishermanymc can you please enable CircleCI to access this repository? |
Sure. Done. There is a CircleCI setup branch now: |
Thanks @fishermanymc. Removed github actions and setup the CircleCI file to build and test the module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for setting it up 🎉
Fails due to some unimplemented test.
Involves a build and test step