Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BM-31: Add CircleCI pipeline for building and testing #23

Merged
merged 3 commits into from
Jun 24, 2022
Merged

Conversation

vitsalis
Copy link
Member

Involves a build and test step

@vitsalis vitsalis changed the title BM-31: Add GitHub actions to repository BM-31: Add GitHub actions for building and testing Jun 22, 2022
@KonradStaniec
Copy link
Collaborator

Just fyi, in previous org/repo we used CircleCi - https://github.com/babylonchain-io/bbld/pull/2/files, due to the fact that github actions at some point blocked whole org, with explanation that we are somehow in breach of their regulations for crypto projects. Of course they did not provide any detail, and contact with them was terrible. So maybe we should stick with it here also, wdyt @fishermanymc ?

@aakoshh
Copy link
Contributor

aakoshh commented Jun 22, 2022

I am not familar with Github Actions, so this may be a stupid question, but why do we need a separate workflow for build and test, why not have one workflow with both steps? Both run on main at the moment, but it's not clear in what order.

@vitsalis
Copy link
Member Author

@aakoshh Not a requirement, I just figured that building and testing might have separate workflows in the future which would warrant some separation. Can combine those and achieve the same result for now.

@fishermanymc
Copy link

Just fyi, in previous org/repo we used CircleCi - https://github.com/babylonchain-io/bbld/pull/2/files, due to the fact that github actions at some point blocked whole org, with explanation that we are somehow in breach of their regulations for crypto projects. Of course they did not provide any detail, and contact with them was terrible. So maybe we should stick with it here also, wdyt @fishermanymc ?

Agreed. Let's avoid Github Action. Last time it thought we were using it for mining and red flag our entire organization and does not allow me to appeal. Let's use Circle CI.

@vitsalis
Copy link
Member Author

Sounds good. @fishermanymc can you please enable CircleCI to access this repository?

@fishermanymc
Copy link

Sounds good. @fishermanymc can you please enable CircleCI to access this repository?

Sure. Done. There is a CircleCI setup branch now:
https://github.com/babylonchain/babylon/tree/circleci-project-setup

@vitsalis vitsalis changed the title BM-31: Add GitHub actions for building and testing BM-31: Add CircleCI pipeline for building and testing Jun 22, 2022
@vitsalis
Copy link
Member Author

Thanks @fishermanymc. Removed github actions and setup the CircleCI file to build and test the module.

Copy link
Contributor

@aakoshh aakoshh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for setting it up 🎉

Fails due to some unimplemented test.

@vitsalis vitsalis merged commit 3643002 into main Jun 24, 2022
@vitsalis vitsalis deleted the github-action branch June 24, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants