Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add e2e test to CI #259

Merged
merged 2 commits into from
Jan 2, 2023
Merged

add e2e test to CI #259

merged 2 commits into from
Jan 2, 2023

Conversation

KonradStaniec
Copy link
Collaborator

@KonradStaniec KonradStaniec commented Jan 2, 2023 •
edited
Loading

  • fixes wrapper script env variable
  • adds e2e tests to CI. For those just launch two chains and relayer, and check that proper connection can be established between two chains. This rather smoke test than proper e2e test, but it is better to have it on CI either way, as otherwise such things quickly rot. (I have already needed to fix some stuff regarding starting script)

@KonradStaniec KonradStaniec marked this pull request as ready for review January 2, 2023 13:12
vitsalis
vitsalis approved these changes Jan 2, 2023
View reviewed changes
test/e2e/containers/containers.go
Mounts: []string{
fmt.Sprintf("%s/:/data/node0/babylond", valCondifDir),
fmt.Sprintf("%s/:/babylondata", valCondifDir),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that!

@KonradStaniec KonradStaniec merged commit 7c544bf into dev Jan 2, 2023
@KonradStaniec KonradStaniec deleted the e2e-test-ci branch January 2, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitsalis vitsalis vitsalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KonradStaniec @vitsalis