chore: refactor FinalizedChainInfo API
#268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moved metadata (raw ckpt, epoch info, btc submission key) out from the proof as per an offline discussion with @vitsalis . These fields are useful for the frontend to display info relevant to the timestamps. |
vitsalis
approved these changes
Jan 11, 2023
| import "babylon/checkpointing/bls_key.proto"; | ||
| import "babylon/checkpointing/query.proto"; | ||
| import "babylon/checkpointing/checkpoint.proto"; | ||
| import "babylon/epoching/v1/epoching.proto"; |
There was a problem hiding this comment.
Do we need all those extra imports?
There was a problem hiding this comment.
Nice catch. I have cleaned up dependencies in zoneconcierge.proto and query.proto. Too bad I cannot find a linter for protobuf things 😓
| } | ||
|
|
||
| return nil | ||
| } |
|
btw can we also update the swagger docs given that the proto files were upgraded. |
KonradStaniec
added a commit
that referenced
this pull request
Jan 12, 2023
* zoneconcierge: API for querying the chain info of a given epoch (#260) * zoneconcierge: API for querying headers in a given epoch (#261) * zoneconcierge API: adding total number of timestamped headers to chainInfo (#263) * zoneconcierge API: find the BTC-finalised chain info before specific CZ height (#264) * zoneconcierge API: find header and fork headers at a given height (#266) * checkpointing API: add checkpoint lifecycle in `RawCheckpointWithMeta` (#267) * chore: refactor `FinalizedChainInfo` API (#268) * Add integration test for zoneconcierge checkpointing (#269) * Add integration test checking info about opposing cz chain * Fix: Increase gas in e2e test (#270) Increase gas * fix: checkpointing: Do not make the `home` flag a required one and unmarshall PubKey (#271) * Fix build Co-authored-by: Runchao Han <[email protected]> Co-authored-by: Vitalis Salis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
FinalizedChainInfoAPI in the following aspects:Proveis set to betrue. This is because the oracle page does not need them if it does not verify the timestamp's correctness. We omit them to reduce the overhead of this API.ProofFinalizedChainInfothat contains everything needed for verifying a finalised chain info. This will be reused by theFinalizedChainInfoUntilHeightAPI.FuzzHeader