Integrate wasmd #324
Integrate wasmd #324
Conversation
KonradStaniec
force-pushed
the
integrate-wasmd
branch
2 times, most recently
from
8acc694
to
7b868c4
Compare
app/app.go
Outdated
| // The last arguments can contain custom message handlers, and custom query handlers, | ||
| // if we want to allow any custom callbacks | ||
| // See https://github.com/CosmWasm/cosmwasm/blob/main/docs/CAPABILITIES-BUILT-IN.md | ||
| availableCapabilities := "iterator,staking,stargate,cosmwasm_1_1,cosmwasm_1_2" |
There was a problem hiding this comment.
Can we define this to a more visible place?
Further, what's the reasoning behind the decision to enable those?
There was a problem hiding this comment.
iterator seems like really basic feature to have (it enables iteration over keystore in smart contract)
stargate is IBC so seems useful
cosmwasm_1_1,cosmwasm_1_2 are just some new feature added to cosmwasm, so it is probably be good to be up to date
One thing which is debatable is staking.
In general, I can create some ADR which describes all capabilities first and then we may talk it out on some eng meeting. Current version is just reasonable default. I will left TODO here.
There was a problem hiding this comment.
Sounds good to me, let's nail down the capabilities we want to have enabled
KonradStaniec
force-pushed
the
integrate-wasmd
branch
from
5f1089a
to
ef416fa
Compare
Initial integration with wasmd.
Currently it uses this commit of wasmd repo - https://github.com/CosmWasm/wasmd/tree/7e936c7fffb6f489ed9ecb797a7a2823a032b10b
There will be at least one follow up task - #335