fix: fix query height in ProveEpochSealed
#352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
ProveEpochSealed.When executing an ABCI query
abci.RequestQuery, one needs to feed aheight, such that the node will reply an inclusion proof of the queried KV pair against the header atheight+1.We use this ABCI query for generating proofs of inclusion for the validator set and the metadata of epoch
iagainst the sealer header, i.e., the 2nd header of epochi+1. In order to allow verifier to verify the proofs against the sealer header, the ABCI query should be given heightqueryHeight-1rather thanqueryHeight, wherequeryHeightwill be the sealer header's height. This PR fixes the bug where we usequeryHeightrather thanqueryHeight - 1.The corresponding unit test is also fixed.