Wire up grandpa decoder to babylon custom logic #360
Conversation
| @@ -35,6 +39,25 @@ func GetHeaderInfo(ctx sdk.Context, m exported.ClientMessage) *HeaderInfo { | |||
| ChaindId: msg.Header.ChainID, | |||
| Height: uint64(msg.Header.Height), | |||
| } | |||
| case *ibcwasm.Header: | |||
| // try to decode wasm.data as a picasso header | |||
| gh, err := grandpa.DecodeHeader(grandpa.NewDecoder(bytes.NewReader(msg.Data))) | |||
There was a problem hiding this comment.
@blasrodri just to be sure, does ibcwasm.Header.Data field contains only serialized picasso header or there is some other data here ?
There was a problem hiding this comment.
It only contains grandpa light-client header
There was a problem hiding this comment.
oh and how this header relates to the header parser that Eduardo implemented here - https://github.com/babylonchain/babylon/blob/centauri-integration-ibc-v7-stable/x/zoneconcierge/types/grandpa/header.go ?
| return nil | ||
| } | ||
|
|
||
| return &HeaderInfo{ |
There was a problem hiding this comment.
don't you need any extra validation? Just asking, I'm totally new to it :)
There was a problem hiding this comment.
it does not need more validation as it is called only in our modified UpdateClient function after client message is already verified with VerifyClientMessage and CheckForMisbehaviour.
This function should probably be package private, but this just a detail :)
Hooks up picasso header decoding to babylon custom checkpointing logic