Improve btccheckpointinfo rpc #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitsalis
approved these changes
May 2, 2023
| // the BTC checkpoint transactions on the above block | ||
| repeated TransactionInfo earliest_btc_block_txs = 4; | ||
| // the BTC checkpoint transactions of the best submission | ||
| repeated TransactionInfo best_submission_transactions = 4; | ||
| // list of vigilantes' addresses |
There was a problem hiding this comment.
Suggested change
| // list of vigilantes' addresses | |
| // list of vigilantes' addresses of the best submission |
x/btccheckpoint/types/types.go
Outdated
| // Index of the latest transaction in youngest submission block | ||
| LatestTxIndex uint32 | ||
| YoungestBlockInitialTxIdx uint32 |
There was a problem hiding this comment.
hmm yea it a bit weird. Maybe lowest will be better ? As this is only used for tie resolving, and this is transaction with lowest transaction idx in youngest block.
KonradStaniec
force-pushed
the
improve-btccheckpointinfo-rpc
branch
from
3ee8033
to
e2bcae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves
BtcCheckpointInfoquery:As far as performance go this pr does not make any changes. Most probably biggest performance hit in this endpoint is the fact of linear scans when calling
MainChainDepth. One hacky improvement would be to avoid callingMainChainDepthwhen epoch is finalized, as then we know for sure that submission is on main chain and deep enough so we could only callBlockHeightcall, but I would avoid doing this if the performance unless it is critical.Imo it is better to wait for improved btc lightclient.