feat: Create datagen testutil for common random generation functions #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
reviewed
Jul 8, 2022
Comment on lines
+23
to
24
| func GenRandomBtcdHeader(version int32, bits uint32, nonce uint32, | ||
| timeInt int64, prevBlockStr string, merkleRootStr string) *wire.BlockHeader { |
There was a problem hiding this comment.
One useful function would be to create a header that extends a parent.
In that case you already have a parent hash, but you can also reuse the same version, and make sure the time is incremented by a random amount, but isn't less.
That can be used to generate a full block tree, recursively.
There was a problem hiding this comment.
Yep that would be super useful and I intend to implement it when doing keeper tests. Let's implement it when it is needed.
aakoshh
reviewed
Jul 8, 2022
x/btclightclient/types/msgs_test.go
Outdated
| // If the header hex is the same as the default one, then this is the seed input | ||
| headerBytes := bbl.NewBTCHeaderBytesFromBlockHeader(btcdHeader) | ||
| headerHex := headerBytes.MarshalHex() | ||
| seedInput := types.DefaultBaseHeaderHex == headerHex | ||
|
|
||
| // Make the address have a proper size | ||
| if len(addressBytes) == 0 || len(addressBytes) >= 256 { | ||
| addressBytes = genRandomByteArray(1 + uint64(rand.Intn(257))) | ||
| addressBytes = datagen.GenRandomByteArray(1 + uint64(rand.Intn(257))) |
There was a problem hiding this comment.
Why the 1 +? It looks like this will go up to 257.
aakoshh
reviewed
Jul 8, 2022
aakoshh
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be useful in #47 since it uses similar functions with the ones used on the
btclightclientmodule.