Add tests to ci #90
Add tests to ci #90
Conversation
KonradStaniec
force-pushed
the
add-step-to-ci
branch
8 times, most recently
from
b4a893d
to
731b690
Compare
KonradStaniec
force-pushed
the
add-step-to-ci
branch
from
731b690
to
2d95bdb
Compare
There was a problem hiding this comment.
There was some dind package we used in the past to be able to run Docker in Docker:
https://discuss.circleci.com/t/how-to-do-dind-docker-in-docker/32444
| @@ -99,7 +99,8 @@ endif | |||
| all: tools build lint test | |||
|
|
|||
| # The below include contains the tools and runsim targets. | |||
| include contrib/devtools/Makefile | |||
| # TODO: Fix following make file so it will work on linux | |||
There was a problem hiding this comment.
Strage, it works for me locally.
There was a problem hiding this comment.
yep it also works on my mac. I intend to install linux vm locally and check it out
| @@ -19,19 +20,25 @@ jobs: | |||
| command: "go env" | |||
| - restore_cache: # restores saved cache if no changes are detected since last run | |||
| keys: | |||
| - go-mod-v5-{{ checksum "go.sum" }} | |||
| - go-mod-v6-{{ checksum "go.sum" }} | |||
There was a problem hiding this comment.
Why does this have to change?
There was a problem hiding this comment.
paths in docker executor and linux vm executor are different, so under old key dependencies was cached under wrong path. The easiest way around that is to update key version. Old key will expire after some time (I remember on github actions it was 7 days, here I am not sure)
| docker: | ||
| - image: cimg/go:1.18 | ||
| machine: | ||
| image: ubuntu-2204:2022.07.1 |
There was a problem hiding this comment.
What installs go into this image?
There was a problem hiding this comment.
This image already has go 1.18 installed- https://discuss.circleci.com/t/linux-machine-executor-update-2022-july-q3-update/44873
There was a problem hiding this comment.
Ah cool, I didn't know it was Circle CI specific and not some base Ubuntu. Thanks
| - image: cimg/go:1.18 | ||
| machine: | ||
| image: ubuntu-2204:2022.07.1 | ||
| resource_class: large |
There was a problem hiding this comment.
It decides on size of the machine - https://circleci.com/docs/using-linuxvm#available-linuxvm-resource-classes. Large seemed like nice mid point.
Adds integration tests to CI.
Main change needed to achieve that was to change execution env from
dockertolinuxVMas docker execution environment does not support communication between primary container and containers started via docket composeI needed to disable one makefile compilation target i.e
# include contrib/devtools/Makefile, due to some weird error which touches make compilation rules:contrib/devtools/Makefile:61: *** target pattern contains no '%'. Stop.From what I read this has to something to do most probably with some stray colon -
https://stackoverflow.com/questions/47078108/how-do-i-fix-makefile1-target-pattern-contains-no-stop
https://stackoverflow.com/questions/15113138/target-pattern-contains-no-makefile
although I am unable to pinpoint which, and would prefer to fix it in separate pr to not block this one, as having even simple integration tests will enable catching many potential issues quickly. (like not updated docker containers version etc.)