Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVXP-2784 - Add poetry #1

Merged
merged 2 commits into from
Mar 27, 2024
Merged

DEVXP-2784 - Add poetry #1

merged 2 commits into from
Mar 27, 2024

Conversation

vschoener
Copy link
Collaborator

@vschoener vschoener commented Mar 26, 2024

This PR adds poetry and do a refactoring with disutils and packaging pytorch/pytorch#69894 (comment)

Let me know if we need to do more change or iterate :)

Also, the tests are failing for test_libyear on master cause the requirement have changed since the las time. it feels a bit flaky btw.

@vschoener vschoener changed the title Poetry DEVXP-2784 - Add poetry Mar 26, 2024
Copy link
Collaborator

@vitorquintanilha vitorquintanilha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the lock file with poetry lock --no-update. Also tests should work once we add pytest-vcr as a dev requirement.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@vschoener
Copy link
Collaborator Author

poetry lock --no-update

I would have been surprised if the test would work with this package ^^. I have the same remaining error, see the capture

image

@vschoener
Copy link
Collaborator Author

poetry lock --no-update

I would have been surprised if the test would work with this package ^^. I have the same remaining error, see the capture

image

Tests work by running poetry run pytest but not with the IDE (PyCharm)

@vschoener vschoener merged commit a9f4cee into master Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants