Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #35: On demand transcription #97

Merged
merged 8 commits into from
Aug 3, 2023
Merged

Conversation

HeySreelal
Copy link
Contributor

Changes

  • Added /transcribe command - to transcribe the reply_to_message
  • Added the property transcribeAllAudio in the database as per this suggestion
  • Updated help message and en.yaml and ru.yaml to reflect the change
  • Added /transcribeAll command to toggle the transcribeAllAudio property value.

Note:
All the guidelines from #53 have been followed.

Hopefully fixes #35.

@backmeupplz
Copy link
Owner

@HeySreelal lgtm, did you test it manually?

@HeySreelal
Copy link
Contributor Author

Good to hear that. Yes, I tested it manually.

If you want to go a testing round I can start a test bot and share the bot details maybe?

@backmeupplz
Copy link
Owner

@HeySreelal nah, YOLO

@backmeupplz
Copy link
Owner

@HeySreelal can you fix yarn lint, please?

@HeySreelal
Copy link
Contributor Author

Sure, let me check that in a moment...

@HeySreelal
Copy link
Contributor Author

The yarn lint shows warnings on unused-vars.

  67:16  warning  'sendToTelegramAdmin' is defined but never used  @typescript-eslint/no-unused-vars
  87:46  warning  'info' is assigned a value but never used        @typescript-eslint/no-unused-vars

I see that you've removed the error logging in this commit: 548ae0c.

Should I enable it back or just add some ignore flags?

@HeySreelal
Copy link
Contributor Author

I just referenced all the unused identifiers inside the report method. Please let me know if you're actually looking to enable the logging or if this is fine :)

@backmeupplz backmeupplz merged commit 2434e4e into backmeupplz:main Aug 3, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transcribe audios only when requested
2 participants