update core package dependency material-table to 1.69.0 #2263
Conversation
alileza
force-pushed
the
update_material_table
branch
from
cf774da
to
2677066
Compare
alileza
force-pushed
the
update_material_table
branch
from
2677066
to
3d40abb
Compare
|
Hi! Any particular reason this is a draft? Would be happy to merge |
|
also done in #2248 but that one forgot to check in yarn.lock |
|
Ah shoot, that build error again - you may want to upgrade the yarn.lock version to 2.1.0 i think parallax/jsPDF#2846 (comment) |
|
Fixed in parallax/jsPDF@ab21994#diff-b9cfc7f2cdf78a7f4b91a753d10865a2, so hopefully working in the next release |
|
Hi @freben yeah I'm trying to figure out the issue with those e2e doesn't seem to work, I'd update the PR once jspdf fixes went through. But we need to wait for |
|
We could probably bump the resolved version in yarn.lock manually to 2.1.0, right? https://github.com/MrRio/jsPDF/releases/tag/v2%2C1%2C0 |
|
Ah sorry, it's a fixed version dep :/ |
alileza
force-pushed
the
update_material_table
branch
from
ace197b
to
44c94aa
Compare
|
still the same error with version 2.1.0, I tested this locally, seems like |
|
👋 @alileza and I work together and are both trying to solve this issue so whichever PR works better works for us 😄 |
|
for more context, I tried the route suggested above and manually bumped the resolved versions in our own yarn.lock for our instance of backstage generated via the cli and we are able to build successfully, avoiding the FileSaver.js issue on our github deprived CI system, but apparently there is a breaking change and the UI does not render |
|
OK. When they cut a new release of material-table this should be easier to fix fully. I guess we wait a bit... They seem to have a somewhat frequent release cadence and they have bumped to the fixed version in master. Or are you blocked to such a degree that we should even do something more drastic like downgrading far enough that the jspdf dependency is gone? |
|
we are unblocking ourselves for now, but it would be great to get this fixed asap. I can imagine we are not the only ones experiencing this pain. |
|
This is done in #2782 |
this is the same as mbrn#2442 which was closed. ## Related Issue Relate the Github issue with this PR using backstage/backstage#2263 ## Description Simple words to describe the overall goals of the pull request's commits. ## Additional Notes jspdf fileSaver issue parallax/jsPDF#2490. When the dependency configured to fetch directly from github, this caused an issue while running npm install in isolated environment, and the issue already been patched in jspdf, we just need to do an update here
Hey, I just made a Pull Request!
This update is needed to fix an issue if jspdf fileSaver issue parallax/jsPDF#2490. When the dependency configured to fetch directly from github, it caused a problem when npm install runs in infrastructure that unable to access github.com.
This changes as the changelog of material-table shown did an update to jspdf 2.0.0 which don't rely on file-saver dependency anymore
jspdf changelog update: mbrn/material-table@v1.68.0...v1.69.0#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R85
✔️ Checklist
yarn test