Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace distutils copy_tree with shutil.copytree #115

Closed
wants to merge 1 commit into from

Conversation

piotr1212
Copy link

@piotr1212 piotr1212 commented Nov 2, 2023

distutils is removed from Python 3.12

fixes:

  File "/opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/site-packages/mkdocs_monorepo_plugin/merger.py", line 16, in <module>
    from distutils.dir_util import copy_tree
ModuleNotFoundError: No module named 'distutils'

distutils is removed from Python 3.12
@baer95
Copy link

baer95 commented Nov 14, 2023

Hey @agentbellnorm is there any chance to get this reviewed and merged?

@agentbellnorm
Copy link
Contributor

agentbellnorm commented Dec 4, 2023

@piotr1212 Changes look good! Could you also update the changelog and setup.py? That way this will go out immediately without having to create a separate PR: https://github.com/backstage/mkdocs-monorepo-plugin#release

@hairmare
Copy link

this probably fixes #117

@bih
Copy link
Collaborator

bih commented Jan 3, 2024

Although this was created earlier, I see #118 also solves the problem. I'll merge that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants