Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work to do reliable backup of SSM parameters #1

Open
wants to merge 14 commits into
base: reviewed
Choose a base branch
from

Conversation

michael-paddle
Copy link
Collaborator

Initial PR for all work needed to get MVP reliable backup of SSM parameters.

@michael-paddle michael-paddle changed the title Tested Initial work to do reliable backup of SSM parameters Nov 26, 2019
@@ -0,0 +1,41 @@
AWS_ACCOUNT_NAME ?= michael

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove all AWS defaults ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's there as a reminder to set up credentials which make it difficult to accidentally do things on production. Will become clear when I add CI.

AWS_ACCOUNT_NAME ?= michael
AWS_DEFAULT_REGION ?= eu-west-1
PYTHON ?= python3
BEHAVE ?= behave

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to be used anywhere.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above - will commit to clear this up soon

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
The CLI tool provides a simple interface to dump or restore the full
set of SSM parameters.

1) set up the appropriate environment including AWS variables

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be more specific ?
For example for DR, I would like just to copy/past steps.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added.

setup.py Show resolved Hide resolved
backup_cloud_ssm/aws_ssm_dict.py Outdated Show resolved Hide resolved
# full pytest tests so that failures are detected early where possible.
test: develop pytest-mocked behave pytest

behave:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the comments for the each command (ideally on the same line as the command name) - see the comment about the help command below.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-paddle could you please add this? It is not super clear what each command does

pytest:
pytest

wip: develop

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wip ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work in progress - standard behave / BDD development acronym

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what Johan means is it is not clear what this command does.


# develop is needed to install scripts that are called during testing
develop: .develop.makestamp

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If needed, can we add setup command ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's useful; setup alone doesn't get you to a state where the test cases can pass. I'd rather not get that as something people expect to run until the time that we have it as a useful thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants