Update to v2: new CLI #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change interface to python command line
Next commit guess: more typos
query vs ref sparse distances not supported or used
Deal with in same way as GPU, set to infinity
Add sparse query which sparisifies on the fly
|
FYI @muppi1993 @nickjcroucher @richfitz Once merged, this will update the major version of sketchlib. The python API is mostly unchanged, but the CLI will change completely. Don't think it should affect any of your work, but just thought I'd note this in case it does break anything. |
|
Thanks - can you update the pypi version? |
|
(Should) also fixes #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges #66 and #67, ready for a new release
Closes #58