Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve efficiency of sparse queries #94

Merged
merged 22 commits into from
Mar 22, 2024
Merged

Improve efficiency of sparse queries #94

merged 22 commits into from
Mar 22, 2024

Conversation

johnlees
Copy link
Member

@johnlees johnlees commented Mar 16, 2024

Use a priority queue while building instead of a sort

Also replacing robin_hood map with newer https://github.com/martinus/unordered_dense

TODO: Now fixed, braces were simply in the wrong place, error unfortunately reported confusing location
Getting an error

Progress (CPU): 0.1%terminate called after throwing an instance of 'std::runtime_error'
  what():  Kmer length 14 not found in sketch SAMD00083451

Happens on different samples, can't pin down with printf or gdb.

Wondering if there's a segfault somewhere else, may need valgrind

@johnlees johnlees marked this pull request as ready for review March 19, 2024 19:19
Copy link
Collaborator

@nickjcroucher nickjcroucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks brilliant, just a couple of queries, thanks!

README.md Show resolved Hide resolved
setup.py Show resolved Hide resolved
src/api.cpp Show resolved Hide resolved
@johnlees johnlees merged commit adf033f into master Mar 22, 2024
4 checks passed
@johnlees johnlees deleted the sparse-efficiency branch March 22, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants