Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG layout when a minimum font size is enforced #848

Closed
insin opened this issue Jan 5, 2017 · 2 comments · Fixed by #1132
Closed

SVG layout when a minimum font size is enforced #848

insin opened this issue Jan 5, 2017 · 2 comments · Fixed by #1132
Labels
bug Bugs in badges and the frontend core Server, BaseService, GitHub auth frontend The React app and the infrastructure that supports it

Comments

@insin
Copy link

insin commented Jan 5, 2017 •
edited
Loading

I use my browser's minimum font size setting to prevent sites from using unreadable font sizes. Unfortunately it has this effect on shields.io SVG badges:

firefox_2017-01-05_19-31-57

Is there something which could be done to make SVG badges scale instead of squishing text like this?
@insin insin mentioned this issue Jan 5, 2017
Open
@paulmelnikow
Copy link
Member

Thanks for this issue.

This would be great to fix. Can you give steps to reproduce the problem?

@paulmelnikow
Copy link
Member

Maybe duplicate of: #746 #797

@paulmelnikow paulmelnikow added bug Bugs in badges and the frontend frontend The React app and the infrastructure that supports it labels Apr 17, 2017
@paulmelnikow paulmelnikow added the core Server, BaseService, GitHub auth label Oct 2, 2017
@paulmelnikow paulmelnikow mentioned this issue Oct 4, 2017
Closed
@RedSparr0w RedSparr0w mentioned this issue Oct 5, 2017
Merged
paulmelnikow pushed a commit that referenced this issue Oct 9, 2017
@RedSparr0w @paulmelnikow
Fix enlarged text when min-font-size is enabled (#1132)
7db325c 
Fixes #746 
Fixes #848 

Works by making the font-size `110px` instead of `11px` so the browser doesnt enforce the minimum font size and then scales the text down to 10%.

Also fixes the padding issue on Firefox.
paulmelnikow pushed a commit that referenced this issue Oct 12, 2017
@RedSparr0w @paulmelnikow
Fix letter spacing on Windows Firefox, Badge padding to spec (#1161)
7945db8 
Update of #1132
Fix #746 #848
@paulmelnikow paulmelnikow mentioned this issue Oct 5, 2019
Open
@paulmelnikow paulmelnikow mentioned this issue Oct 13, 2019
Open
@paulmelnikow paulmelnikow mentioned this issue Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bugs in badges and the frontend core Server, BaseService, GitHub auth frontend The React app and the infrastructure that supports it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix enlarged text when min-font-size is enabled RedSparr0w/shields
2 participants
@insin @paulmelnikow