-
Notifications
You must be signed in to change notification settings - Fork 214
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(parsing): parsing www.github.com urls
fixes #15
- Loading branch information
Showing
5 changed files
with
77 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,10 @@ | ||
var la = require('lazy-ass'); | ||
var check = require('check-more-types'); | ||
var describeIt = require('describe-it'); | ||
var getReadmeFilename = require('path').join(__dirname, 'get-readme.js'); | ||
var utils = require('./utils'); | ||
|
||
/* global it */ | ||
/* global describe, it */ | ||
|
||
describeIt(getReadmeFilename, 'maybeGithubRepoName(name)', function () { | ||
describe('maybeGithubRepoName(name)', function () { | ||
it('returns true for common repos', function () { | ||
var cases = [ | ||
'foo/bar', | ||
|
@@ -14,48 +13,48 @@ describeIt(getReadmeFilename, 'maybeGithubRepoName(name)', function () { | |
'bevacqua/es6' | ||
]; | ||
cases.forEach(function (c) { | ||
la(this.maybeGithubRepoName(c), c); | ||
}.bind(this)); | ||
la(utils.maybeGithubRepoName(c), c); | ||
}); | ||
}); | ||
|
||
it('returns false for non repos', function () { | ||
la(!this.maybeGithubRepoName('foo/bar/baz')); | ||
la(!this.maybeGithubRepoName('[email protected]:bahmutov/object-fitter.git')); | ||
la(!utils.maybeGithubRepoName('foo/bar/baz')); | ||
la(!utils.maybeGithubRepoName('[email protected]:bahmutov/object-fitter.git')); | ||
}); | ||
}); | ||
|
||
describeIt(getReadmeFilename, 'maybeGithubRepoUrl(name)', function () { | ||
describe('maybeGithubRepoUrl(name)', function () { | ||
it('returns true for common repo urls', function () { | ||
var cases = [ | ||
'https://github.com/bevacqua/es6', | ||
'[email protected]:bevacqua/es6.git' | ||
]; | ||
cases.forEach(function (c) { | ||
la(this.maybeGithubRepoUrl(c), c); | ||
}.bind(this)); | ||
la(utils.maybeGithubRepoUrl(c), c); | ||
}); | ||
}); | ||
}); | ||
|
||
describeIt(getReadmeFilename, 'parseGithub(url)', function () { | ||
describe('parseGithub(url)', function () { | ||
it('parses es6 repo url', function () { | ||
var url = 'https://github.com/bevacqua/es6'; | ||
var parsed = this.parseGithub(url); | ||
var parsed = utils.parseGithub(url); | ||
la(check.object(parsed), parsed); | ||
la(parsed.user === 'bevacqua', 'invalid username', parsed); | ||
la(parsed.repo === 'es6', 'invalid repo', parsed); | ||
}); | ||
|
||
it('parses es6 .git repo url', function () { | ||
var url = '[email protected]:bevacqua/es6.git'; | ||
var parsed = this.parseGithub(url); | ||
var parsed = utils.parseGithub(url); | ||
la(check.object(parsed), parsed); | ||
la(parsed.user === 'bevacqua', 'invalid username', parsed); | ||
la(parsed.repo === 'es6', 'invalid repo', parsed); | ||
}); | ||
|
||
it('parses user/repo format', function () { | ||
var url = 'bevacqua/es6'; | ||
var parsed = this.parseGithub(url); | ||
var parsed = utils.parseGithub(url); | ||
la(check.object(parsed), parsed); | ||
la(parsed.user === 'bevacqua', 'invalid username', parsed); | ||
la(parsed.repo === 'es6', 'invalid repo', parsed); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
var log = require('debug')('manpm'); | ||
var la = require('lazy-ass'); | ||
var check = require('check-more-types'); | ||
var parseGithubRepoUrl = require('parse-github-repo-url'); | ||
|
||
// TODO move to kensho/check-more-types | ||
function maybeGithubRepoName(name) { | ||
var regular = /^[a-zA-Z0-9]+\/[a-zA-Z0-9\-\.]+$/; | ||
return regular.test(name); | ||
} | ||
|
||
function maybeGithubRepoUrl(name) { | ||
return Array.isArray(parseGithubRepoUrl(name)); | ||
} | ||
|
||
function parseGithub(url) { | ||
log('parsing github url', url); | ||
var parsed = parseGithubRepoUrl(url); | ||
la(check.array(parsed), 'could not parse github url', url); | ||
return { | ||
user: parsed[0], | ||
repo: parsed[1] | ||
}; | ||
} | ||
|
||
module.exports = { | ||
maybeGithubRepoName: maybeGithubRepoName, | ||
maybeGithubRepoUrl: maybeGithubRepoUrl, | ||
parseGithub: parseGithub | ||
}; |