Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom registry and timeout #117

Merged
merged 5 commits into from
Nov 6, 2017
Merged

Conversation

xpure-sklatt
Copy link
Contributor

This provides 2 new options:

  • --registry to set a custom registry url (including https and credentials)
  • --check-version-timeout to set custom timeout value when checking for new version

Makes it possible to use custom npm registries that require https and user/password authenfication as well as a custom timeout value for fetching the new version numbers.

@coveralls
Copy link

coveralls commented Nov 6, 2017

Coverage Status

Coverage remained the same at 78.137% when pulling 0b56fd4 on xpure-sklatt:master into 9205cc6 on bahmutov:master.

package.json Outdated
@@ -1,7 +1,7 @@
{
"name": "next-update",
"description": "Tests if module's dependencies can be updated to the newer version without breaking the tests",
"version": "0.0.0",
"version": "3.5.3",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this - this module is using semantic-release to set the next version automatically

@bahmutov
Copy link
Owner

bahmutov commented Nov 6, 2017

Great feature @xpure-sklatt but can you just remove the version from the package.json and I will merge it

@coveralls
Copy link

coveralls commented Nov 6, 2017

Coverage Status

Coverage remained the same at 78.137% when pulling ea268cc on xpure-sklatt:master into 9205cc6 on bahmutov:master.

@xpure-sklatt
Copy link
Contributor Author

Cool, thanks @bahmutov! I've just reset the version to 0.0.0

@bahmutov bahmutov merged commit ad2cf7b into bahmutov:master Nov 6, 2017
@bahmutov
Copy link
Owner

bahmutov commented Nov 6, 2017

Great, merged it in, hope to publish soon @xpure-sklatt

@xpure-sklatt
Copy link
Contributor Author

Awesome, I'm looking forward to use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants