fix peerid #455
Open
fix peerid #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehds
added a commit
to ehds/mbraft
that referenced
this pull request
Jun 10, 2024
pick: baidu/braft#455 Co-authored-by: yangzining.yzn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PeerId 增加了 role，但是它的 operator < 和 operator == 没有考虑 role。
PeerId 的 operator < 被 std::map 使用(包括 Configuration/node_manager)。没有考虑 role 会导新建一个 addr、idx 相同但是角色不同的节点时失败。