Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge 2.9 to master #1320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

merge 2.9 to master #1320

wants to merge 1 commit into from

Conversation

baobaoyeye
Copy link
Collaborator

No description provided.

@smwyzi
Copy link
Member

smwyzi commented Mar 13, 2018

LGTM

@lylei
Copy link
Collaborator

lylei commented Mar 13, 2018

编译check没通过？

@yvxiang
Copy link
Collaborator

yvxiang commented Mar 13, 2018

  1. 先编译通过

  2. 都包含哪些改动，能拆吗？不能拆的话，如何知道哪个commit引入了哪些bug，或者哪个commit影响了性能

@Ye-Tian-Zero
Copy link
Contributor

统一回复下，因为2.9的tera依赖改动后的sofa-pbrpc，所以编译挂了。
rpc那边的pr我明天修改后重新提一下。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smwyzi smwyzi Awaiting requested review from smwyzi

@elithnever elithnever Awaiting requested review from elithnever

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@baobaoyeye @smwyzi @lylei @yvxiang @Ye-Tian-Zero