Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

producer chart: job/cronjob switch #110

Merged
merged 4 commits into from
Aug 2, 2021
Merged

Conversation

mkcode92
Copy link
Contributor

  • make producer-app deployable as job
  • problem: when switching between job/cronjob a lot of shared config is needed in a different path (spec.template vs spec.jobTemplate.spec.template)
  • this block is now separated as podTemplate

@yannick-roeder
Copy link
Member

yannick-roeder commented Jul 27, 2021

LGTM, did you test it?

@torbsto
Copy link
Contributor

torbsto commented Jul 27, 2021

@VictorKuenstler @philipp94831 This is a fix for the changes introduced by #108. I've mistakenly assumed that Job and CronJob have the same spec besides schedule. Obviously, the changes in this PR are more complex than those in #108. I still think it's worth to have it.

@mkcode92 I think you also have to update the producer-app chart according to the steps listed here: https://github.com/bakdata/streams-bootstrap/tree/master/charts#development

@yannick-roeder
Copy link
Member

@mkcode92 I think you also have to update the producer-app chart according to the steps listed here: https://github.com/bakdata/streams-bootstrap/tree/master/charts#development

True, thanks @torbsto

@mkcode92
Copy link
Contributor Author

LGTM, did you test it?

Yes, both should work!

@mkcode92 mkcode92 changed the title Feature/producer job switch producer chart: job/cronjob switch Jul 30, 2021
@mkcode92 mkcode92 merged commit 059e6a6 into master Aug 2, 2021
@philipp94831 philipp94831 deleted the feature/producer-job-switch branch August 20, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants