Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add optimism rpc url to envs #418

Merged
merged 2 commits into from
Sep 24, 2024
Merged

chore: add optimism rpc url to envs #418

merged 2 commits into from
Sep 24, 2024

Conversation

agualis
Copy link
Contributor

@agualis agualis commented Sep 24, 2024

Fixes integration tests by:

  1. Replacing optimism fallback rpc url from https://optimism.gateway.tenderly.co (was failing) to https://optimism.llamarpc.com (more stable according to https://chainlist.org/chain/10)

  2. Defining OPTIMISM_RPC_URL in CI and vitest setup.

The last step would be defining the OPTIMISM_RPC_URL env in the repo secrets.

@agualis
Copy link
Contributor Author

agualis commented Sep 24, 2024

@johngrantuk Do you have permissions to add OPTIMISM_RPC_URL to the secrets?

Copy link
Member

@johngrantuk johngrantuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johngrantuk
Copy link
Member

@johngrantuk Do you have permissions to add OPTIMISM_RPC_URL to the secrets?

Yeah, I've added it now. Thanks for fixing it!

@agualis agualis merged commit 1d6af52 into main Sep 24, 2024
4 checks passed
@agualis agualis deleted the optimism-env branch September 24, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants