[WIP] V3 nested pool support #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrently failing, assuming because of router.
…g, possibly due to router.
…portional 258 remove liquidity nested proportional
MattPereira
reviewed
Oct 24, 2024
Comment on lines
+39
to
+52
| // Address of the highest level pool (which contains BPTs of other pools), i.e. the pool we wish to join | ||
| const parentPool = nestedPoolState.pools.reduce((max, curr) => | ||
| curr.level > max.level ? curr : max, | ||
| ); | ||
| // query function input, `tokensIn` array, must have all tokens from child pools | ||
| // and all tokens that are not BPTs from the nested pool (parent pool). | ||
| const mainTokens = nestedPoolState.mainTokens.map( | ||
| (t) => new Token(input.chainId, t.address, t.decimals), | ||
| ); | ||
| // This will add 0 amount for any tokensIn the user hasn't included | ||
| const maxAmountsIn = getAmounts(mainTokens, input.amountsIn, 0n); | ||
|
|
||
| // Query the router to get the onchain amount | ||
| // Note - tokens do not have to be sorted, user preference is fine |
There was a problem hiding this comment.
Excellent job explaining the trickier parts / nuances with these comments 👏
MattPereira
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Minor inconsequential suggestion, but might make sense to have only one test file that runs both .buildCall and .buildCallWithPermit2 for the addLiquidityNestedV3 ( unless I'm missing good reason is better to split? )
There was a problem hiding this comment.
Goes back to what we were discussing in our last meeting - I thought it was quite hard to follow approvals, etc in the other tests where everything is nested deeply and this was an attempt to make it easier to understand.
MattPereira
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still to do:
Closes #257