Nested pools release #448
Merged
Nested pools release #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattPereira
reviewed
Oct 29, 2024
| * V3 nested removes are always proportional. | ||
| * User must approve composite router to spend BPT token - See tests in test/v3/removeLiquidityNested for full flow. | ||
| * (Runs against a local Anvil fork) | ||
| * Note - remove transaction is not fully run in this example because we cannot use slot method to artificially give test account BPT balance. |
There was a problem hiding this comment.
When we get around to the major refactor of examples, should be able to give test account BPT by performing an add liquidity behind the scenes in fork setup right?
There was a problem hiding this comment.
Yeah, exactly. Didn't want to get too deep into that at this stage.
MattPereira
reviewed
Oct 29, 2024
Comment on lines
+76
to
+93
| console.table({ | ||
| tokensOut: queryOutput.amountsOut.map((a) => a.token.address), | ||
| amountsOut: queryOutput.amountsOut.map((a) => a.amount), | ||
| }); | ||
| console.log(`BPT In: ${queryOutput.bptAmountIn.amount.toString()}`); | ||
|
|
||
| // Build the transaction data with slippage applied | ||
| const call = removeLiquidityNested.buildCall( | ||
| removeLiquidityNested.buildRemoveLiquidityInput(queryOutput, { | ||
| slippage, | ||
| }), | ||
| ); | ||
|
|
||
| console.log('\nWith slippage applied:'); | ||
| console.table({ | ||
| tokensOut: call.minAmountsOut.map((a) => a.token.address), | ||
| minAmountsOut: call.minAmountsOut.map((a) => a.amount), | ||
| }); |
There was a problem hiding this comment.
Love the tables!
In some future refactor, maybe we combine them into single table that includes difference btwn query and minAmountsOut after slippage is applied to group data and make a little easier to digest
MattPereira
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Hell of a lot easier to follow than makeForkTx 👏
Nice job exposing the approval steps!
MattPereira
reviewed
Oct 29, 2024
Comment on lines
+313
to
+315
| // TODO - Leave this in as useful as basis for manual debug | ||
| // await client.simulateContract({ | ||
| // address: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.