-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring update pool weights #541
Refactoring update pool weights #541
Conversation
hey -- could you change target branch to |
@thetroyharris is it ready for review? can you verify why there's a diff at |
bda3f76
to
06a0cb1
Compare
ecb917b
to
2acdefc
Compare
@mendesfabio I am investigating an issue with the results of these changes. |
ok, just let me know when I can get back to review it |
@thetroyharris I'm confused if I should start reviewing it - can you please mark as ready for review if that's the case? |
28bdad2
to
64da743
Compare
I will be building locally moving forward to decrease the frequency of the CI tests. My apologies. |
yes you should run |
can you share the deployment URL? |
Mainnet: https://api.thegraph.com/subgraphs/id/QmSJZTgfEpeVadrkpNjafFvnpgSVzPxMV3XK1cB9EdDp3Z Goerli: https://api.thegraph.com/subgraphs/name/thetroyharris/test Note: I am actively performing tests on Goerli to resolve a bug where the |
f39c572
into
balancer:refactor-update-weights
Description
Refactoring of the
updatePoolWeights
function to no longer uses calls to retrieve token weight information. Instead this token weight information is calculated given the block time and lastGradualWeightUpdateScheduled
event information.Type of change
How should this be tested?
Please provide instructions so we can test. Please also list any relevant details for your test configuration.
Checklist:
dev
->master
Merges to
dev