fix negative total shares and holders count #595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#591 fixed a scope issue where
Pool
entity was not saved before being passed/instantiated to another functions. OOTH that fix exposed another issue ashandleTransfer()
not only substracts the pre-minted BPT from the Vault (that's just what we need) but also subtracts the value frompool.totalShares
leading to negative shares. Instead of using the function, I'm simply subtracting the pre-minted BPTs from Vault's pool share directly.Type of change
How should this be tested?
Please provide instructions so we can test. Please also list any relevant details for your test configuration.
Checklist:
dev
->master
Merges to
dev