Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Affine Ultra LRTs #114

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Add Affine Ultra LRTs #114

merged 4 commits into from
Aug 26, 2024

Conversation

mkflow27
Copy link
Collaborator

@mkflow27 mkflow27 commented Jul 24, 2024 •
edited
Loading

Fixes #96
Fixes #97
This pr adds review for Affine's UltraLRT.

Outstanding activities:

  • peer review

@mkflow27 mkflow27 changed the title Mkflow27/issue96 Add Affine Ultra LRTs Jul 24, 2024
@mkflow27 mkflow27 marked this pull request as ready for review July 24, 2024 08:16
@mkflow27 mkflow27 requested a review from danielmkm July 24, 2024 08:16
danielmkm
danielmkm approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@danielmkm danielmkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this earlier alongside @mkflow27. The review looks good, but we should push for them to increase the minDelay on the timelock before we merge.

@mkflow27
Copy link
Collaborator Author

mkflow27 commented Aug 26, 2024 •
edited
Loading

minDelay was upgraded to 86400. https://etherscan.io/tx/0x2433bd3d140f2b3a1455c18107c88ede9aa14881fd4138293ab95c4b61998a48#eventlog

@danielmkm

@mkflow27 mkflow27 merged commit 7f66e21 into main Aug 26, 2024
1 check passed
@mkflow27 mkflow27 deleted the mkflow27/issue96 branch August 26, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmkm danielmkm danielmkm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Affine UltraEthS Rate Provider Affine UltraEth Rate Provider
2 participants
@mkflow27 @danielmkm