Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sUSX Rate Providers #117

Merged
merged 3 commits into from
Jul 31, 2024
Merged

sUSX Rate Providers #117

merged 3 commits into from
Jul 31, 2024

Conversation

mkflow27
Copy link
Collaborator

@mkflow27 mkflow27 commented Jul 29, 2024 •
edited by danielmkm
Loading

Fixes #102

Outstanding activities:

  • reread
  • peer review
  • add factory to registry

@mkflow27 mkflow27 requested a review from danielmkm July 31, 2024 12:42
@mkflow27 mkflow27 marked this pull request as ready for review July 31, 2024 12:42
danielmkm
danielmkm approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@danielmkm danielmkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good, thanks for the additional notes

@mkflow27 mkflow27 merged commit 10d69d1 into main Jul 31, 2024
1 check passed
@mkflow27 mkflow27 deleted the mkflow27/issue102 branch July 31, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmkm danielmkm danielmkm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sUSX Rate Providers
2 participants
@mkflow27 @danielmkm