Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Affine Rate Providers (2) #159

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Affine Rate Providers (2) #159

merged 3 commits into from
Oct 1, 2024

Conversation

mkflow27
Copy link
Collaborator

Fixes #149

@mkflow27
Copy link
Collaborator Author

@Zen-Maxi Can you ask about the proposer and/or executor roles on their timelock controller. Currently both are EOAs. Would be good if you can confirm with them.

@maruf0011
Copy link

@mkflow27
On our timelock controller only multisig has propose role. executor is address(0), so anyone can execute proposal after passing multisig.

  1. timelock: https://etherscan.io/address/0x4B21438ffff0f0B938aD64cD44B8c6ebB78ba56e
  2. multisig: https://etherscan.io/address/0x67Ec3Bb25a5DB6eB7Ba74f6C0b2bA193A3983FB8

@mkflow27
Copy link
Collaborator Author

@maruf0011 Thanks for the clarification.

danielmkm
danielmkm approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@danielmkm danielmkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mkflow27

@mkflow27 mkflow27 merged commit 60b7519 into main Oct 1, 2024
1 check passed
@mkflow27 mkflow27 deleted the mkflow27/issue149 branch October 1, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmkm danielmkm danielmkm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Affine Rate Providers (2)
3 participants
@mkflow27 @maruf0011 @danielmkm