Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legacy rps #63

Merged
merged 16 commits into from
May 15, 2024
Merged

Add legacy rps #63

merged 16 commits into from
May 15, 2024

Conversation

mkflow27
Copy link
Collaborator

@mkflow27 mkflow27 commented May 6, 2024

This pr adds the following additions:

  • Adds legacy rateProviders and introduces LegacyReview.md
  • Adds ChainLinkRateProviders and introduces ChainLinkRateProvider.md
  • Adds "fantom" as a network entry & adds sftmx
  • Adds linter
  • Adds json Schema validation
  • Adds github actions which validate the registry.json

Before this gets merged we should aim to add all the remaining assets to the RateProviders. Outstanding

  • Update not added assets.

After this pr has been merged

@mkflow27 mkflow27 requested review from franzns and Zen-Maxi May 6, 2024 11:15
Copy link
Collaborator Author

@mkflow27 mkflow27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Factory needs updating

rate-providers/registry.json Outdated Show resolved Hide resolved
Copy link
Contributor

@franzns franzns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mkflow27 for these changes. I like the schema validation you put in place!

Copy link
Collaborator

@Zen-Maxi Zen-Maxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with the revised review md files and formatting. Maxis will take responsbility of adding Chainlink rate providers as they are created as well as any others if they are not already included in this list.

@mkflow27 mkflow27 merged commit 1a874a1 into main May 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants