-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating registry #66
Conversation
Based on this sheet, did not add any from Fantom or below 500 USD TVL. https://docs.google.com/spreadsheets/d/1I7OsWcO__6B73Nsuukb3DErnDa5IjjKEaWwqAQiMVuE/edit#gid=0 Some rate providers are actually totally wrong and unsafe. Maybe better we dont make a habit of adding those; so new users cannot use or see them. Other option would be add every rate provider ever even if unsafe or wrong; to me that sounds bloated. |
@Zen-Maxi I think unsafe rate providers should not ever be added to this registry. Only scenario I see to have an unsafe Rate Provider in here is if it was previously safe and a change in circumstances made it unsafe. |
We should not add wrong ones. How the API/UI will handle this is that all on this list would be flagged as a warning and the UI would disable deposit actions on the pool |
Isnt that the case for the reth rateprovider on arb? |
I would rather not include the unsafe rate providers unless they went from safe to unsafe like you guys have signalled above. As for the unused / old ones it may be best to leave them out entirely. A handful of fixes and recent Chainlink additions are in this PR but removing the ones that were never safe is also fine by me if we all agree. |
@Zen-Maxi Sure, if you could remove all the unsafe rateProviders that were not "safe" once and resolve conflicts I will review. |
Removed unsafe, was only jAura (not wrapped) and bitfrost vETH in wrong direction (decreasing). Rest are either safe, or were and are now unsafe.
Does the order of addition matter?
Sounds good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Zen-Maxi
No description provided.