Architecture article tweaks #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy this pull request to the Balancer Team on Vercel. To accomplish this, the commit author's email address needs to be associated with a GitHub account. Learn more about how to change the commit author information. |
mkflow27
requested changes
Jul 2, 2024
There was a problem hiding this comment.
Thanks Juani, the changes are great and increase accuracy of the page imo. In my preview the images have transparent background. Other images I have used in the docs have white background. I think it would be good to change the images to have white background.
|
@mkflow27 thanks for the comments; done! Is there a way to have a different picture for dark mode? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces improved simplified / detailed architecture diagrams that are a closer match to the current state of the code (e.g. invoke vs tab, calls / data split, etc).
The description was re-arranged to match the proposed steps in each case.