Update pool-exits.md #170
Open
Update pool-exits.md #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Encoding section for Proportional and Custom Exits.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Encoding section for Proportional and Custom Exits.
Determined and confirmed through testing that these two definitions were mixed up. See the below transactions on Metis Goerli and note the
userDatafields for further proof. Contract addresses also included for reference.Proportional Exit (returning all 3 specified tokens back from estimated BPT amount): https://goerli.explorer.metisdevops.link/tx/0x9b9e873461007d2fb0950d24a22eff87cfb4647c1f5d89c19867d1551bec1463
Proportional Exit (returning only 2 specified tokens back from estimated BPT amount): https://goerli.explorer.metisdevops.link/tx/0x2ea019ecc160448689100f3d46bbccba7b9eece05d579447d390e0978e157a24
Custom Exit (returning estimated amounts of all 3 tokens from exact BPT amount): https://goerli.explorer.metisdevops.link/tx/0x21af9d0f17773d134e9384098864844c11baf35782577af14058357fce10b1be
Vault: https://goerli.explorer.metisdevops.link/address/0xAd8Ab48eD57F35dCD2a0c67Bfc5c91d35bF1C5b4
Tri Stable ComposableStablePoolV5 (containing mock ERCs for USDC/USDT/DAI): https://goerli.explorer.metisdevops.link/address/0xBf49cC8510040B71AF73bD4A9fcEB70EBDA0C108