Igor's feedback on docs [WIP] #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It states that Token Accounting and Pool Logic are separated but it is not explained how. I think it is important to have at least high level understanding how exactly accounting is separated from pool logic. Maybe a diagram displaying all possible interactions between Vault and Pool can shed light on this.
Deploying with
|
| Latest commit: |
5f707c5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://80eadf76.balancer-docs.pages.dev |
| Branch Preview URL: | https://ylv-io-patch-1.balancer-docs.pages.dev |
|
Should be an issue not PR |
mkflow27
pushed a commit
that referenced
this pull request
Feb 21, 2024
* WIP * tabs structure * tempale ui complete * calendar-lockTime componenst * install web3modal + basic implementation * move stuff into Wallet component * wip * VeSystem Overview (data fetching) (#5) * Add LaunchpadSubgraph class * fetch launchpad data from subgraph * update UI with data * change UI max-lock time (#3) * change UI max-lock time * Changed max lock time calculation --------- Co-authored-by: Pablo F. Mescher <[email protected]> * wip * create Admin Panel + default tabs * launchpad hooks: deploy, refactor deploy form * submit button indicator * List token names (#7) * Admin Panel - Rewards Distribution / Admin Pools (#8) * RewardsDistribution Tab * Admin Pools (no design) * Basic Tab Navigation * Available rewards modal placeholder (#9) * Replace lauchpadProvider by VeSystemProvider (#10) * Admin Pools (#11) * Set Multiple Available Rewards (#12) Co-authored-by: Luigi <[email protected]> * VeSystem Config Fields (#13) * Ve System Config Fields and Buttons (#14) * Ve system config unlock all (#15) * Ve System Config - Early Unlock (#16) * Fixed Modals UI (#17) * Set Early Penalty Speed & fix styles (#18) * Added search by bptToken address functionality (#19) Co-authored-by: Luigi <[email protected]> Co-authored-by: esis8 <[email protected]> * Non admin flow pool details / lock (#20) * Tab Navigation * Pool Details Button * Lock Action * Approve Action * Pool Details Tab Data * Non Admin Flow - Withdraw (#21) * Adapt UI to work with new subgraph schema (#23) * Claim Modal (#22) * Update launchpad contract address (#24) * Available Rewards Modal (#25) * Properly formatting numbers (#26) * Admin Pools: Search by vested token address (#27) * Add Supply Vested % (#28) * fixed size buttons (#29) * Fix Calendar timestamp for adding rewards exact week (#30) * Network support first round (#33) * Add Polygon zkEVM * add config file * fixed design btn selector (#32) * Add contract addresses (#34) * add contract addresses * add subgraph urls * Missing Non Admin Feautures (#31) * EarlyWithdraw * increase_amount * increase_unlock_time * Increase Lock Detalis Modals (#35) * Add to early penalty * change texts * rename search placeholder * add activation functionality checkboxes (#36) * launchpad start-time fix * change texts * allow increase unlock * update contract address and abi * Claim External Rewards * catch error * fix lock timestamp issue * change title for user section * max lock time changes * Only Mumbai * add ethereum to fix issue * fix timezone issue (#37) * Network Support (#38) * networks: polygon, arbitrum, mumbai * Scope veSystems by admin (#40) * list veSystems by admin * fix switch network * remove code redundancy * Tooltips (#39) * Network support (#44) Add support for: * mainnet * optimisim * avalanche * base * gnosis Update contract addresses * Replace mumbai with sepolia (#45) * Added detailed documentation (#52) * Documentation added * Detailed docs and changes to launchpad page * Update admin-ve8020.md --------- Co-authored-by: Pablo F. Mescher <[email protected]> Co-authored-by: esis8 <[email protected]> Co-authored-by: E Esis <[email protected]> Co-authored-by: Pablo F. Mescher <[email protected]> Co-authored-by: burns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vault
It states that Token Accounting and Pool Logic are separated but it is not explained how. I think it is important to have at least high level understanding how exactly accounting is separated from pool logic. Maybe a diagram displaying all possible interactions between Vault and Pool can shed light on this.