Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add appName to whitelisted connection options #501

Merged

Conversation

DominusKelvin
Copy link
Collaborator

@sailsbot
Copy link
Collaborator

Thanks for submitting this pull request, @DominusKelvin! We'll look at it ASAP.

In the mean time, here are some ways you can help speed things along:

  • discuss this pull request with other contributors and get their feedback. (Reactions and comments can help us make better decisions, anticipate compatibility problems, and prevent bugs.)
  • ask another JavaScript developer to review the files changed in this pull request. (Peer reviews definitely don't guarantee perfection, but they help catch mistakes and enourage collaborative thinking. Code reviews are so useful that some open source projects require a minimum number of reviews before even considering a merge!)
  • if appropriate, ask your business to sponsor your pull request. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • make sure you've answered the "why?" (Before we can review and merge a pull request, we feel it is important to fully understand the use case: the human reason these changes are important for you, your team, or your organization.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@sereisoglu
Copy link

Hi @DominusKelvin, This PR seems to be approved, when can you release a new version?

@DominusKelvin
Copy link
Collaborator Author

Hi @DominusKelvin, This PR seems to be approved, when can you release a new version?

Hey I'm scheduled to do that tomorrow during our open source sync. Thanks for your patience.

@DominusKelvin DominusKelvin merged commit a63ec9c into balderdashy:master Sep 12, 2024
4 checks passed
@DominusKelvin
Copy link
Collaborator Author

Hey @eashaw, this PR has been merged and you can proceed to releasing a patch to NPM. Thank you buddy!

cc @sereisoglu

@DominusKelvin DominusKelvin deleted the feat/add-appName-to-constants branch September 12, 2024 19:05
@sereisoglu
Copy link

Hey @DominusKelvin, It seems that the new version has not been released, is there a problem?

@DominusKelvin
Copy link
Collaborator Author

Hey @DominusKelvin, It seems that the new version has not been released, is there a problem?

Hey I can see 2.1.2 was released 2 days ago. Can you confirm you've got it?

@sereisoglu
Copy link

Hey @DominusKelvin, It seems that the new version has not been released, is there a problem?

Hey I can see 2.1.2 was released 2 days ago. Can you confirm you've got it?

Sorry, Yes the new version is out. Thanks! I was checking here: releases.

@DominusKelvin
Copy link
Collaborator Author

Hey @DominusKelvin, It seems that the new version has not been released, is there a problem?

Hey I can see 2.1.2 was released 2 days ago. Can you confirm you've got it?

Sorry, Yes the new version is out. Thanks! I was checking here: releases.

Oh yeah, I'll cut new release on GH too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

srv support in the connection url for sails-mongo
4 participants