-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use shallow merge in res.view (re #3500)
- Loading branch information
1 parent
6f35bad
commit 5861f65
Showing
1 changed file
with
3 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5861f65
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading all through #3500 I'm not sure this is actually necessary. We should make a test to be sure, although it's tricky to even tell what the failing case would be. Like you said, we never explicitly documented that this was a merge, but if we don't need to change it, might as well just document the way it currently works rather than making a breaking change.