Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] ignoring deeply nested changes #3526

Closed
mikermcneil opened this issue Jan 25, 2016 · 3 comments
Closed

[email protected] ignoring deeply nested changes #3526

mikermcneil opened this issue Jan 25, 2016 · 3 comments

Comments

@mikermcneil
Copy link
Member

It seems that there are other issues with grunt-contrib-watch @ version 0.6.1. Changes to deeply nested files are not noticed-- switching to [email protected] solves the problem.

Will need to dig deeper into this grunt plugin to see if there are any related issues there (otherwise we'll have to revert to 0.5.x as the generated dep version in new sails apps or figure something else out)

Tested with:

    "sails": "0.11.3",
    "grunt": "0.4.5",
    "grunt-contrib-clean": "0.6.0",
    "grunt-contrib-coffee": "0.13.0",
    "grunt-contrib-concat": "0.5.1",
    "grunt-contrib-copy": "0.5.0",
    "grunt-contrib-cssmin": "0.9.0",
    "grunt-contrib-jst": "0.6.0",
    "grunt-contrib-less": "1.1.0",
    "grunt-contrib-uglify": "0.7.0",
    "grunt-contrib-watch": "0.6.1",
    "grunt-sails-linker": "0.10.1",
    "grunt-sync": "0.2.4",
∑ npm -v
2.8.4
∑ node -v
v0.10.26
@mikermcneil
Copy link
Member Author

For the record (since it's mattered re: filesystem watching in the past) I'm on OS X 10.10.5.

If anyone has a moment to try out this version of grunt-contrib-watch on Node 4 or another OS, and report their findings, that'd be awesome.

@sgress454
Copy link
Member

I think reverting to 0.5.3 should be fine. There wasn't anything in the changelog that would particularly apply to Sails; I mostly bumped it because "remove deprecated grunt.util libs" sounded like something that would give us a few less NPM warnings in our install.

mikermcneil added a commit that referenced this issue Feb 3, 2016
mikermcneil added a commit that referenced this issue Feb 5, 2016
@mikermcneil
Copy link
Member Author

This will be changed back to 0.5.3 (and pinned) in 0.12 (so this issue should never affect apps using a stable version of Sails)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants