Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sails 0.12.11 DeprecationWarning: Using Buffer without new will soon stop working. #3909

Closed
kpturner opened this issue Dec 3, 2016 · 6 comments

Comments

@kpturner
Copy link

kpturner commented Dec 3, 2016

Sails version: 0.12.11
Node version: 7.2.0
NPM version: 4.0.3
Operating system: Centos 6.5


A depreciation warning gets thrown when lifting sails and navigating to one of my routes. This started occuring after upgrading to Node 7.0.0.

(node:3244) DeprecationWarning: Using Buffer without new will soon stop working. Use new Buffer(), or preferably Buffer.from(), Buffer.allocUnsafe() or Buffer.alloc() instead.
at Buffer (buffer.js:79:13)
at C:\app\node_modules\crc\lib\crc32.js:17:11
at fn (C:\app\node_modules\crc\lib\create.js:5:12)
at hash (C:\app\node_modules\express-session\index.js:528:10)
Looks like express-session needs upgrading to the latest version (1.14.1)

@sailsbot
Copy link

sailsbot commented Dec 3, 2016

Hi @kpturner! It looks like you missed a step or two when you created your issue. Please edit your comment (use the pencil icon at the top-right corner of the comment box) and fix the following:

  • Verify "I am experiencing a concrete technical issue (aka a bug) with Sails (ideas and feature proposals should follow the guide for proposing features and enhancements (http://bit.ly/sails-feature-guide), which involves making a pull request). If you're not 100% certain whether it's a bug or not, that's okay--you may continue. The worst that can happen is that the issue will be closed and we'll point you in the right direction."
  • Verify "I am not asking a question about how to use Sails or about whether or not Sails has a certain feature (please refer to the documentation(http://sailsjs.org), or post on http://stackoverflow.com, our Google Group (http://bit.ly/sails-google-group) or our live chat (https://gitter.im/balderdashy/sails)."
  • Verify "I have already searched for related issues, and found none open (if you found a related closed issue, please link to it in your post)."
  • Verify "My issue title is concise, on-topic and polite ("jst.js being removed from layout.ejs on lift" is good; "templates dont work" or "why is sails dumb" are not so good)."
  • Verify "I have tried all the following (if relevant) and my issue remains:"
  • Verify "I can provide steps to reproduce this issue that others can follow."

As soon as those items are rectified, post a new comment (e.g. “Ok, fixed!”) below and we'll take a look. Thanks!

If you feel this message is in error, or you want to debate the merits of my existence (sniffle), please contact [email protected].

@kpturner
Copy link
Author

kpturner commented Dec 3, 2016

Ok, fixed!

@kpturner
Copy link
Author

kpturner commented Dec 3, 2016

This not be a sails issue but perhaps node-crc

@mikermcneil
Copy link
Member

@kpturner regardless, thanks for the heads up! We'll want to get rid of the message nonetheless, just because it's scary to folks new to Node (and it's not something that shows up in our tests)

@mikermcneil
Copy link
Member

Hm well actually, this should be fixed... (see #3875) (and also rebased to master for Sails v1 e256ecf)

looking into it

@mikermcneil
Copy link
Member

@kpturner (going to go ahead and close this so we can bring #3872 back to life instead.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants