-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depreciation warning from express-session #3872
Comments
This was just fixed in express-session a few hours ago. I had to wait for our dependency to publish to npm. I will publish a new version of express-session soon. You'll need 1.14.2+ |
Cool thanks, looks like 1.14.2 is published to npm. |
@boycce @dougwilson Thanks guys. We'll get it sorted asap and publish sails 0.12.9. |
and e256ecf |
@boycce Sails 0.12.9 has been published, with @mikermcneil's patch. Give it a while when you have a chance and let us know that this issue has been resolved for you! |
I am on node 7.2 and Sails 0.12.11 and I still get this error |
Reopening-- this should be fixed (see #3909 (comment)) but apparently not |
@kpturner wondering if maybe your app needs a (See expressjs/session#380) |
Here are the Sails tests running on Node 7: https://travis-ci.org/balderdashy/sails/jobs/181786499 (I would expect to see the warning in there-- not guaranteed or anything, but probably) But @kpturner if you find that the npm install doesn't do the trick, just let us know. Thanks! |
Sails version: 0.12.10 |
Maybe you'll find this more interesting: $ grep -rnw ./node_modules -e "= Buffer("
./node_modules/sails-postgresql/node_modules/pg/test/unit/client/md5-password-tests.js:6: var salt = Buffer([1, 2, 3, 4]); |
At this point, you should probably just upgrade to Node.js 7.2.1. The deprecation was decided to be a mistake and has been reverted in Node.js 7.2.1. |
ah indeed |
...but in a test? What? |
But humor me, if you would:
^^Looking for |
(or higher) |
In addition to the previous comment, for me the warning arrives as soon as connection is made from a browser. It also occurs when the application is running under a service (with forever) and the service is stopped. |
@kpturner the issue in sails wasn't fixed until version 0.12.9, but your install has an older version. |
Yes you are right. The global install of sails is v0.12.11 but the application has a built in dependency on ~0.11.5. However, if I force it to use 0.12.11 it all falls apart - none of the passport code seems to work properly. Also the dependencies for sails.js pulls in express-handlebars will installs a version of graceful-fs which will fail on node 7. So, all in all, I think I will have to live with the warning as I don't have time to investigate all the issues that have arisen from using 0.12.11 at the moment :( |
@kpturner another option is just upgrade to Node.js 7.2.1. The deprecation was decided to be a mistake and has been reverted in Node.js 7.2.1. |
Not sure what's up with the |
Sails version: 0.12.8
Node version: 7.0.0
NPM version: 3.10.8
Operating system: Windows 7 (64bit)
A depreciation warning gets thrown when lifting sails and navigating to one of my routes. This started occuring after upgrading to Node
7.0.0
.Looks like
express-session
needs upgrading to the latest version (1.14.1)The text was updated successfully, but these errors were encountered: