Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The Electron version we’re currently using is on Node 13 (?) but this is a step forward to upgrading to a newer Electron and Node version. Updates etcher-sdk and switches the redundant aws4-axios dependency to just axios. Also changed bundler to stop trying to bundle wasm files — they must be included inline with JS code as data — and removed some now redundant code. The crucial changes that enable support are: 1. The update to etcher-sdk@8 where some dependency fixes and updates took place 2. The downgrade and pinning of "electron-rebuild" to v3.2.3 until we’re able to update to Electron >= 14.2. The patch we need to avoid is electron/rebuild#907. Also see: nodejs/node-gyp#2673 and electron/rebuild#913 3. A rule in webpack.config to ignore `aws-crt` which is a dependency of (ultimately) `aws4-axios` which is used by etcher-sdk and does a runtime check to its availability. We’re not currently using the “assume role” functionality (AFAIU) of aws4-axios and we don’t care that it’s not found, so force webpack to ignore the import. See aws/aws-sdk-js-v3#3025 Change-type: minor
- Loading branch information